search

ghalex / vue3-charts

Vue3-Charts is an SVG-based charting library that is very easy to use and highly customizable
https://vue3charts.org
MIT License
142 stars 23 forks source link

Feature/axis config #13

Closed nVitius closed 3 years ago

nVitius commented 3 years ago

This patch adds a way to add more advanced configuration to an Axis. Also, I was having an issue with the text on the Y axis getting clipped. Found out it was because the values for the axis size were fixed. I added a ResizeObserver to both the X and Y axis that will update the config for the axisSpace. I've also cleaned up the TypeScript types a bit.

I added a commit to remove the lockfile from the lib. Lockfiles shouldn't be committed to npm packages: https://www.twilio.com/blog/lockfiles-nodejs

ghalex commented 3 years ago

This is great work @nVitius thank you for this.

nVitius commented 3 years ago

@ghalex Thanks for merging my PR I saw that you bumped the version in the package file, but it hasn't been published to npm yet. Can you update here when you've had a chance to do that?

ghalex commented 3 years ago

I see something is not working with the publish pipeline after you removed the package-lock.json. I will take a look these days and fix it.