Add sorting option to pie chart

ghalex / vue3-charts

Vue3-Charts is an SVG-based charting library that is very easy to use and highly customizable

https://vue3charts.org

MIT License

142 stars 23 forks source link

Add sorting option to pie chart #18

Closed pvanagtmaal closed 2 years ago

pvanagtmaal commented 2 years ago

Hi, me again :)

Thanks for merging my previous PR so quickly!

I have yet another addition, a smaller one this time. D3 apparently automatically sorts the pie wedges in a descending order, but I need a custom sorting option. I have added a few options:

desc: regular descending sort
asc: regular ascending sort
none: no ordering at all
custom: use a custom provided sort function

ghalex commented 2 years ago

Hi, @pvanagtmaal,

Thanks again for your contribution, I was just working on the Pie myself. The Pie didn't support margin correctly and if you used the Responsive component to have dynamic size the Pie didn't update correctly.

I will take a look at the current pull request and approve it.

Thanks, Alexandru

pvanagtmaal commented 2 years ago

Hi @ghalex,

Good to know. Thanks for fixing!

Piet