search

ghammad / pyActigraphy

Python-based open source package for actigraphy data analysis
https://ghammad.github.io/pyActigraphy
GNU General Public License v3.0
136 stars 25 forks source link

Allow passing in threshold for mask creation #129

Closed ugGit closed 1 year ago

ugGit commented 1 year ago

The private method for the inactivity mask creation already accepts an argument to define the threshold, below which consecutive values are forming a period of inactivity. This PR now allows defining the threshold when calling the corresponding public function. The default value is set to match the previously used value (1). Therefore, this change will not break any old code.

The initial propsal for this feature is described further in https://github.com/ghammad/pyActigraphy/issues/128.

ghammad commented 1 year ago

@ugGit would it be possible to merge into the develop branch, instead of the master branch? I keep the master branch for releases and do the dev in feature branches, branching from develop. How easy is it for you to switch?

ugGit commented 1 year ago

Just for reference. This PR was recreated with the develop branch as target https://github.com/ghammad/pyActigraphy/pull/131.