search

ghammad / pyActigraphy

Python-based open source package for actigraphy data analysis
https://ghammad.github.io/pyActigraphy
GNU General Public License v3.0
136 stars 27 forks source link

Add support for Italian RPX files #137

Open ugGit opened 1 year ago

ugGit commented 1 year ago

This PR adds support for RPX files which were exported in Italian as suggested in issue https://github.com/ghammad/pyActigraphy/issues/136. This extends the existing languages English, French, and German.

ugGit commented 1 year ago

I think, it would be great to add another test case. However, I suspect that it might be good to aim for consistency with respect to the test files. Therefore, it would be great if @ghammad could probably generate the file in the same manner as the other RPX files used for tests.

ghammad commented 1 year ago

I think, it would be great to add another test case. However, I suspect that it might be good to aim for consistency with respect to the test files. Therefore, it would be great if @ghammad could probably generate the file in the same manner as the other RPX files used for tests.

@ugGit : could you send an Italian file example you use? In addition, we still need to figure out how "Mobility" and "S/W Status" are translated in Italian and include these translations in the dict.

ugGit commented 1 year ago

Here you go for the file: example_it.csv

The thing with the Mobility and S/W Status is that they are not listed in the columns in my examples. The same already seem to have applied when somebody added support for the german language. Thus, I did not bother me too much.