ghaschel / vscode-angular-html

Angular syntax highlighting for HTML templates
https://marketplace.visualstudio.com/items?itemName=ghaschel.vscode-angular-html
Other
52 stars 4 forks source link

components from primeng are not colored properly #64

Closed sheamer closed 2 years ago

sheamer commented 2 years ago

Describe the bug -Before the latest update this works fine, components from primeng like , , , used to be colored properly. but after the update all of those custom tag components are not colored (white text only) and everything in it is also not colored properly:

List of installed/enabled extensions

OS (please provide the following information):

Expected behavior

1

ghaschel commented 2 years ago

On it.

ghaschel commented 2 years ago

Along with the custom-elements bugfix, I intend to allow PrimeNG tags to be personalized just as with Angular Material... But for that, I need to track all of the PrimeNG elements, and I was able to get all of these from their docs:

Please, let me know if there is any component missing so that I can add to the list.

<p-autocomplete></p-autocomplete>
<p-calendar></p-calendar>
<p-cascadeSelect></p-cascadeSelect>
<p-checkbox></p-checkbox>
<p-chips></p-chips>
<p-colorPicker></p-colorPicker>
<p-dropdown></p-dropdown>
<p-editor></p-editor>
<p-inputMask></p-inputMask>
<p-inputSwitch></p-inputSwitch>
<p-inputNumber></p-inputNumber>
<p-knob></p-knob>
<p-listbox></p-listbox>
<p-multiSelect></p-multiSelect>
<p-password></p-password>
<p-radioButton></p-radioButton>
<p-rating></p-rating>
<p-slider></p-slider>
<p-selectButton></p-selectButton>
<p-toggleButton></p-toggleButton>
<p-treeSelect></p-treeSelect>
<p-triStateCheckbox></p-triStateCheckbox>
<p-button></p-button>
<p-splitButton></p-splitButton>
<p-speedDial></p-speedDial>
<p-dataView></p-dataView>
<p-fullCalendar></p-fullCalendar>
<p-gmap></p-gmap>
<p-orderList></p-orderList>
<p-organizationChart></p-organizationChart>
<p-paginator></p-paginator>
<p-pickList></p-pickList>
<p-table></p-table>
<p-tableHeaderCheckbox></p-tableHeaderCheckbox>
<p-sortIcon></p-sortIcon>
<p-columnFilter></p-columnFilter>
<p-tableCheckbox></p-tableCheckbox>
<p-dialog></p-dialog>
<p-skeleton></p-skeleton>
<p-toast></p-toast>
<p-cellEditor></p-cellEditor>
<p-contextMenu></p-contextMenu>
<p-toolbar></p-toolbar>
<p-fileUpload></p-fileUpload>
<p-confirmDialog></p-confirmDialog>
<p-tableRadioButton></p-tableRadioButton>
<p-timeline></p-timeline>
<p-card></p-card>
<p-tree></p-tree>
<p-treeTable></p-treeTable>
<p-treeTableToggler></p-treeTableToggler>
<p-treeTableSortIcon></p-treeTableSortIcon>
<p-treeTableCheckbox></p-treeTableCheckbox>
<p-treeTableCellEditor></p-treeTableCellEditor>
<p-virtualScroller></p-virtualScroller>
<p-scroller></p-scroller>
<p-accordion></p-accordion>
<p-accordionTab></p-accordionTab>
<p-divider></p-divider>
<p-fieldset></p-fieldset>
<p-panel></p-panel>
<p-menu></p-menu>
<p-splitter></p-splitter>
<p-scrollPanel></p-scrollPanel>
<p-tabView></p-tabView>
<p-tabPanel></p-tabPanel>
<p-confirmPopup></p-confirmPopup>
<p-overlayPanel></p-overlayPanel>
<p-breadcrumb></p-breadcrumb>
<p-dock></p-dock>
<p-megaMenu></p-megaMenu>
<p-menubar></p-menubar>
<p-panelMenu></p-panelMenu>
<p-slideMenu></p-slideMenu>
<p-steps></p-steps>
<p-tabMenu></p-tabMenu>
<p-tieredMenu></p-tieredMenu>
<p-chart></p-chart>
<p-messages></p-messages>
<p-carousel></p-carousel>
<p-galleria></p-galleria>
<p-image></p-image>
<p-avatar></p-avatar>
<p-avatarGroup></p-avatarGroup>
<p-badge></p-badge>
<p-blockUI></p-blockUI>
<p-captcha></p-captcha>
<p-chips></p-chips>
<p-chip></p-chip>
<p-inplace></p-inplace>
<p-progressBar></p-progressBar>
<p-progressSpinner></p-progressSpinner>
<p-scrollTop></p-scrollTop>
<p-skeleton></p-skeleton>
<p-tag></p-tag>
<p-terminal></p-terminal>
Daranix commented 2 years ago

@ghaschel

Some additional tags:

[
    "p-header",
    "p-autoComplete",
    "p-cascadeSelectSub",
    "p-contextMenuSub",
    "p-dropdownItem",
    "p-dynamicDialog",
    "p-inplaceDisplay",
    "p-lightbox",
    "p-menubarSub",
    "p-message",
    "p-multiSelectItem",
    "p-panelMenuSub",
    "p-sidebar",
    "p-slideMenuSub",
    "p-spinner",
    "p-tieredMenuSub",
    "p-toastItem",
    "p-treeNode"
]
ghaschel commented 2 years ago

Thanks for the tags. It will be on the next release.

ghaschel commented 2 years ago

This was implemented on 2.2.1.

Feel free to reopen this issue or open a new one if there's something wrong, or even to request support for new tags

sheamer commented 2 years ago

@ghaschel I'm a fan of your work. Thank you for this!

ghaschel commented 2 years ago

Thank you, I appreciate it. You just made my day.