search

ghazalghorabi / TDA553-lab1

0 stars 0 forks source link

CRITICAL: Missing test of move() #11

Closed martinjonsson01 closed 1 year ago

martinjonsson01 commented 1 year ago

You have not written any tests for the move() method of Car.

https://github.com/ghazalghorabi/TDA553-lab1/blob/9064245501fc0d8910804f850959c9b46f31d00c/test/CarTest.java#L10

martinjonsson01 commented 1 year ago

@hannapanna3 please do not close the issues yourselves. I'll close them when I find that you've fixed them, as per the submission guidelines: "Your grader will close any issues that have been resolved, or update the issue with feedback on why the changes do not resolve the issue."

hannapanna3 commented 1 year ago

Okay, I just did it to keep some order :)

martinjonsson01 commented 1 year ago

Yeah that makes sense. I recommend you leave a comment on the ones you've resolved, rather than closing them. That way you'll be able to tell them apart on your end, and it'll still be clear which ones you've actually been graded as 'passed' on.

martinjonsson01 commented 1 year ago

@hannapanna3 it sounded like you had adressed many of the issues. Don't forget that you should create a new tag (lab1b, lab1c, etc...) and then let me know whenever you want me to take a look at it again.

martinjonsson01 commented 1 year ago

@hannapanna3 igår gjorde ni en merge in i master, men ni skapade aldrig en ny tagg lab1b (ni skapade bara en release länkad till den gamla taggen lab1). Jag antar att ni kände er klara så jag tar och kollar igenom allt nu, men skapa gärna den taggen ändå!