search

ghcjs / diagrams-ghcjs

diagrams backend that renders directly to an HTML5 canvas
Other
23 stars 6 forks source link

Change clipping implementation. #4

Open joelburget opened 10 years ago

joelburget commented 10 years ago

I noticed that some shapes weren't clipped properly so I changed the implementation to be more like the canonical Cairo backend. Now those shapes seem to work. I can add a test if there's interest.

co-dan commented 10 years ago

Thanks a lot for contributing. I would greatly appreciate a test.

Also, would you mind moving the actual clipping part to a separate function, just for the sake of making it more simple to read.

Unrelated to your work and not directed at you, I think this code might need some refactoring in the future. The (newly refactored) Cairo backend might be of inspiration.

co-dan commented 10 years ago

@joelburget hi, any comments/updates on this? I would really appreciate the example you were talking about

joelburget commented 10 years ago

To be honest I don't remember what the problem was. Also my ghcjs setup is lost and I don't really have time to work on this at the moment. Sorry :(