ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC
MIT License
45 stars 67 forks source link

Fix issues with JS backend syntax translation #136

Closed sevanspowell closed 3 months ago

sevanspowell commented 3 months ago

I needed to make these changes to get the miso examples which depend on ghcjs-base (xhr, file-reader, canvas2d) working. There may be more issues introduced by #135, but I don't have test cases for those atm.

I will do a more thorough review if you feel I'm on the right track. This is my first time modifying JS FFI code.

I also needed to make some changes to miso itself, which I will be submitting PRS for soon.

Thanks for your work on the Javascript backend! ❤️

sevanspowell commented 3 months ago

Changes to miso: https://github.com/dmjio/miso/pull/740.

hsyl20 commented 3 months ago

LGTM, thanks!