Should JavaScript.Web.AnimationFrame re-export OnBlocked? - Githubissues

ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC

MIT License

45 stars 67 forks source link

Should JavaScript.Web.AnimationFrame re-export OnBlocked? #35

Closed luite closed 9 years ago

luite commented 9 years ago

Using the AnimationFrame things requires an import of the GHCJS.Foreign.Callback to use the OnBlocked data type, exported by the seemingly unrelated (in hiearchy) module GHCJS.Foreign.Callback.

There's also the same data type in GHCJS.Concurrent, which I think is really the place that it should be in (or at least canonically exported from).

Todo:

Remove OnBlocked from GHCJS.Foreign.Callback, use the one from GHCJS.Concurrent instead
Decide whether GHCJS.Foreign.Callback and JavaScript.Web.AnimationFrame should re-export OnBlocked.

luite commented 9 years ago

Important thing done, getting rid of the duplicate OnBlocked