ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC
MIT License
45 stars 67 forks source link

Non-exhaustive in GFromJSArr instance #64

Open dmjio opened 8 years ago

dmjio commented 8 years ago

Getting the below:

Progress: 1/2
GHCJS/Marshal/Internal.hs:(219,5)-(224,40): Non-exhaustive patterns in case

On generic serialization with a product type that contains a list. There is a partial pattern match here that I believe might be responsible.

https://github.com/ghcjs/ghcjs-base/blob/e9e9e36afde694202de034905efdeef153e1b04d/GHCJS/Marshal/Internal.hs#L220

I believe a Nothing case just needs to be added, if this is correct I can submit a patch.