Bump aeson upper bound to 1.1

ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC

MIT License

45 stars 67 forks source link

Bump aeson upper bound to 1.1 #71

Closed spl closed 7 years ago

spl commented 7 years ago

Does this change require changing shims? I'm now seeing this error in my app, and I think it's related to using aeson-1.0.2.0.

uncaught exception in Haskell thread: ReferenceError: h$_js_decode_string is not defined
all.js:7069 ReferenceError: h$_js_decode_string is not defined
    at h$$kyZ (all.js:535090)
    at h$runThreadSlice (all.js:8018)
    at h$runThreadSliceCatch (all.js:7968)
    at h$mainLoop (all.js:7963)
    at all.js:8506
    at XMLHttpRequest.load (all.js:23707)

tolysz commented 7 years ago

My best guess is to have pure Haskell version for this module, and if it is slower and working it is much better then faster and broken. The choice which module to build should be done in .cabal

alexanderkjeldaas commented 7 years ago

Any solution to this?

tolysz commented 7 years ago

The whole module is a simple function for decoding strings, UTF8->UCS2 please write it in Haskell, or "borrow" from some plethora libraries which does it but are not as performing as the C(state machine) version

hamishmack commented 7 years ago

Closing this as I think this is out of date now. The upper bound is currently 1.2 and my understanding is that aeson-1.1.1.0 includes ghcjs support.