Duplicated h$textFromString

ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC

MIT License

45 stars 67 forks source link

Duplicated h$textFromString #74

Closed vwwv closed 6 years ago

vwwv commented 7 years ago

There are 2 implementations of h$textFromString
- one here
- the other one her
It seems only one of them is used, but not sure which.
Might this issue cause problems when compiling with google's closure compiler? (My text strings containing \n trigger exception when optimized with the closure compiler, could this be related? ).
If there's a reason to have to h$textFromString, do you mind adding a comment explaining it?

hamishmack commented 7 years ago

Looks like jsbits/string.js is not used (only jsbits/text.js) is listed in ghcjs-base.cabal. It also looks like jsbits/string.js uses an older method to write to the ByteArray.