search

ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC
MIT License
45 stars 67 forks source link

Removes redundancies & attoparsec dependency #85

Closed tippenein closed 7 years ago

tippenein commented 7 years ago

While exploring #79 I found that much of the code in Javascript/JSON/Types/Instances was not used. This revealed that the Attoparsec's Number was unused.

The rest of the PR includes removal of redundant pragmas, imports and functions.

hamishmack commented 7 years ago

I am a little bit concerned that some of those imports in JavaScript/JSON/Types/Instances would be needed if the code that has been commented out in that module was added back. Can we comment out the imports in that module (instead of removing them) in to make it easier to add them back if needed?

tippenein commented 7 years ago

The main thing for me was removing the attoparsec dep so we can leave the imports in if you'd like.