PToJSVal be a parent class of IsJSVal?

ghcjs / ghcjs-base

base library for GHCJS for JavaScript interaction and marshalling, used by higher level libraries like JSC

MIT License

45 stars 67 forks source link

PToJSVal be a parent class of IsJSVal? #91

Open louispan opened 7 years ago

louispan commented 7 years ago

This way we can have a consistent way to convert to jsval with just pToJSVal, instead of sometime using jsval sometimes using pToJSVal.

Also currently we can't use pToJSVal to convert Maybe JavaScript.Object to a nullable JSVal, because JavaScript.Object is a IsJSVal but not a pToJSVal.

hamishmack commented 7 years ago

Oops wrong issue

johannesgerer commented 4 years ago

Would this solve https://github.com/ghcjs/jsaddle-dom/issues/15 ?