search

ghcjs / jsaddle

JavaScript interface that works with GHCJS or GHC
118 stars 63 forks source link

Provide a file:// url as a base url for wkwebview #60

Closed adetokunbo closed 6 years ago

adetokunbo commented 6 years ago

Resolves #59 and should eventually lead to a clean solution for https://github.com/reflex-frp/reflex-platform/issues/209

This should mean that users on Mac will no longer need to generate an empty index.html to run the app.

adetokunbo commented 6 years ago

This does fix reflex-frp/reflex-platform#209 as confirmed by feedback on that issue, and I don't think the Travis failure is anything to do with this change. @hamishmack PTAL

hamishmack commented 6 years ago

Thanks, this looks good. Can you please change it to use the current directory (rather than /tmp)? That seems to be what jsaddle-webkit2gtk is doing here. That way any links should work the same.

Can you please update the jsaddle-webkit2gtk to also include "index.html" in the url?

adetokunbo commented 6 years ago

Can you please change it to use the current directory (rather than /tmp)?

Done

Can you please update the jsaddle-webkit2gtk to also include "index.html" in the url?

Done