ghdl / docker

Scripts to build and use docker images including GHDL
40 stars 10 forks source link

Fix permissions of /opt/* directories #16

Closed eine closed 4 years ago

eine commented 4 years ago

[@tmeissner] I've tested the ghdl/synth:formal Docker image. In the image, the tool directories under /opt/ are only readable by root. So, if I run the image as non-root user, I can't use the tools as intended

I can live with installing in /opt, a simple change of permissions would be sufficient for me

[@1138-4EB] 755 is ok?

[@tmeissner] I think so The subdirectories of ghdl and the other tools have correct permissions So, only the 3 directories ghdl, yosys & z3 have to changed to 755

[@1138-4EB] That makes sense. The 'wrong' command is just the mkdir before running tar. The content extracted by tar is correct.

Oh. I'm not using tar anymore. I forgot that. Neither mkdir. The directory is implicitly created by COPY in the dockerfiles:

Although it was reported for ghdl/synth:formal, other images are likely to be affected too. At least ghdl/synth:beta and ghdl/synth:latest.

eine commented 4 years ago

@tmeissner, this should be fixed now. I changed all the images so that tools are installed in /usr/local. Would you mind testing?

tmeissner commented 4 years ago

The tools are found in the ghdl/synth:formal image, so it seems to be working. But none of my test designs are working anymore because of GHDL regressions I assume :-(

eine commented 4 years ago

Oh, that's unfortunate. The tests you contributed to ghdlsynth-beta seem to be passing. Hence, it must be some more advanced feature in your tests. Nevertheless, in this issue I was concerned about permissions issues when you used the images as a non-root user in your scripts. Since it seems to be fixed, I'll close it. Anyway, do not hesitate to ping again, since I might have forgotten to fix some other image...