search

ghdl / docker

Scripts to build and use docker images including GHDL
40 stars 10 forks source link

add centos:7 and centos:8 #38

Closed rodrigomelo9 closed 3 years ago

rodrigomelo9 commented 3 years ago

Hi @eine. This Dockerfile builds GHDL for Centos7 (and also Centos8, commented). Ready to iterate with you guidance :-)

rodrigomelo9 commented 3 years ago

Done @eine. I did my best based on your revision. I left some open conversations when not sure about the result.

rodrigomelo9 commented 3 years ago

Done @eine. Running ./run.sh -c centos 7 and ./run.sh -c centos 8, it finishes without problems. Let me know the next steps :-D

eine commented 3 years ago

Nice! The next step is adding two entries to the matrix in https://github.com/ghdl/docker/blob/master/.github/workflows/test.yml#L35. That's the workflow that will use the build and run images for building GHDL.

I am unsure about run images not containing GNAT. I think it might be necessary to copy /opt/gnat/bin. We'll see...

rodrigomelo9 commented 3 years ago

Pushed. I tried an example using ghdl/run:centos7-gcc and ghdl/run:centos8-gcc and in both cases: ghdl: command not found. Is it because there are missing steps or could be related to not containing GNAT?

eine commented 3 years ago

Pushed. I tried an example using ghdl/run:centos7-gcc and ghdl/run:centos8-gcc and in both cases: ghdl: command not found. Is it because there are missing steps or could be related to not containing GNAT?

The procedure is as follows:

Therefore, ghdl/run: images do never contain GHDL. They contain the runtime dependencies only. ghdl/ghdl images are the ones that have GHDL on top of the run images.

Anywa, I will merge this now and we'll see. I expect some minor issues to arise, but we'll deal with them in some other PR.