Allow config to include encryption

ghdna / athena-express

Athena-Express can simplify executing SQL queries in Amazon Athena AND fetching cleaned-up JSON results in the same synchronous or asynchronous request - well suited for web applications.

https://www.npmjs.com/package/athena-express

MIT License

181 stars 70 forks source link

Allow config to include encryption #5

Closed studmanho closed 5 years ago

studmanho commented 5 years ago

To be able to ass kms keys and encryption type, the config needed to be modified.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 77

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 72:	0.0%
Covered Lines:	3
Relevant Lines:	3

💛 - Coveralls

studmanho commented 5 years ago

Will this get merged in?

studmanho commented 5 years ago

I updated this to bump the package patch version. I wanted to kick of a new npm version so I can get the artifact

ghdna commented 5 years ago

I'll test it and merge the PR. Could you also update the readme docs to include the new params for encryption please?

studmanho commented 5 years ago

I made some changes to the README and I updated the code to make it optional in athenaExpress.js. Take a look

ghdna commented 5 years ago

Thanks. I'll test it when I get home today.

studmanho commented 5 years ago

How did it look?

ghdna commented 5 years ago

Updating readme. Currently shows KmsKey as an independent parameter.