search

ghdna / athena-express

Athena-Express can simplify executing SQL queries in Amazon Athena AND fetching cleaned-up JSON results in the same synchronous or asynchronous request - well suited for web applications.
https://www.npmjs.com/package/athena-express
MIT License
179 stars 70 forks source link

fix: typings of QueryObjectInterface #89

Closed romanlamsal closed 1 year ago

romanlamsal commented 1 year ago

The advanced configuration for queries is missing in the type defs. Also the readme states that pagination is a string, which is not true (technically string and number work, but what would be the point to pass a string).

resolves #88

rehanvdm commented 1 year ago

Yes please. Looks like this lib is not maintained anymore :/

ghdna commented 1 year ago

I'll work on it this weekend.