ghdna / athena-express

Athena-Express can simplify executing SQL queries in Amazon Athena AND fetching cleaned-up JSON results in the same synchronous or asynchronous request - well suited for web applications.
https://www.npmjs.com/package/athena-express
MIT License
181 stars 70 forks source link

chore: upgrade to AWS SDK V3 #94

Closed zebehringer closed 11 months ago

zebehringer commented 1 year ago

I removed the instructions for passing hardcoded access credentials in code. Those can be supplied as environment variables, if that is the way a user wants to go that route, and the SDK will automatically load them

zebehringer commented 1 year ago

I imagine you might want to merge this into a different long running branch besides master, which is fine with me. In the meantime I can include the code from my fork in projects that use it

alfaproject commented 1 year ago

@ghdna we already migrated everything else in our projects to AWS SDK v3 and Athena Express is the last remaining piece. Do you think you will get to this any time soon or should we consider forking for the time being?

marcioolivia commented 1 year ago

@ghdna we already migrated everything else in our projects to AWS SDK v3 and Athena Express is the last remaining piece. Do you think you will get to this any time soon or should we consider forking for the time being?

ghdna commented 1 year ago

It’s definitely a priority for me. Will need to create a new project.

On Mon, Jul 31, 2023 at 14:23 M?rcio Dias @.' via 33Mail @.> wrote:

This email was sent to the alias @.' by ' @.', and 33Mail forwarded it to you. To block all further emails to this alias click here http://www.33mail.com/alias/unsub/41bdfade131b958a27a3e30e285264d5

@ghdna https://github.com/ghdna we already migrated everything else in our projects to AWS SDK v3 and Athena Express is the last remaining piece. Do you think you will get to this any time soon or should we consider forking for the time being?

β€” Reply to this email directly, view it on GitHub https://github.com/ghdna/athena-express/pull/94#issuecomment-1658924179, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGRKZT7564CUO5DKHHDEMTXS7ZZ5ANCNFSM6AAAAAAW6QOJ3Y . You are receiving this because you were mentioned.Message ID: @.***>

lukasnagl commented 1 year ago

Thanks for all the work that has been put into this so far! πŸ™

@ghdna With node 16 going EOL in September, an upgrade of lambda functions running node 18 will use aws-sdk v3 per default. So for us, this is a pressing issue as well. Can we get this to a different release (new major release?) soon?

ghdna commented 1 year ago

Yes, 100%. About time for this change anyway. Will put that into the new release.

On Thu, Aug 17, 2023 at 10:38 Lukas Nagl @.' via 33Mail @.> wrote:

This email was sent to the alias @.' by ' @.', and 33Mail forwarded it to you. To block all further emails to this alias click here http://www.33mail.com/alias/unsub/41bdfade131b958a27a3e30e285264d5

Thanks for all the work that has been put into this so far! πŸ™

@ghdna https://github.com/ghdna With node 16 going EOL in September, an upgrade of lambda functions running node 18 will use aws-sdk v3 per default https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html. So for us, this is a pressing issue as well. Can we get this to a different release (new major release?) soon?

β€” Reply to this email directly, view it on GitHub https://github.com/ghdna/athena-express/pull/94#issuecomment-1682404577, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGRKZSC2EPMJH27L6H27DTXVYUFXANCNFSM6AAAAAAW6QOJ3Y . You are receiving this because you were mentioned.Message ID: @.***>

sr-26 commented 1 year ago

Hi, Athena-Express-Plus is now available and it's a direct fork of Athena-Express. Express Athena Plus is an extension of the original Athena Express library, tailored to work seamlessly with AWS V3 architecture, bringing you the latest enhancements and security features offered by Amazon Web Services. Additionally, it introduces comprehensive parameterized query support, allowing you to build more dynamic and efficient Athena queries within your Node.js applications.

zebehringer commented 11 months ago

Athena-Express-Plus works for us. closing this