search

ghedipunk / PHP-Websockets

A Websockets server written in PHP.
BSD 3-Clause "New" or "Revised" License
913 stars 375 forks source link

I had found two errors #126

Open sdiebel opened 4 years ago

sdiebel commented 4 years ago

PHP 7.3.1 (windows cli)

websockets.php: protected function connect($socket) { $user = new $this->userClass(uniqid('u'), $socket, 1); // I had to add the third argument else E_FATAL

testwebsock.php $echo = new echoServer("0.0.0.0","9000",2048); // Also 3rd argument missing else E_FATAL

Your server and client works very well. Nice work!

adriano-pinaffo commented 2 years ago

Ideally you should add default values for those constructors. I was going to add a pull request to fix that, but I saw there are already 2 PRs for that and nothing was merged. Maybe this project was abandoned?

ghedipunk commented 1 year ago

Not abandoned, but not actively maintained, either.

If there's a bug fix or security issue, I'll merge those quickly, but I won't be adding new features (and if I do develop another Websockets server, it will be hosted on GitLab.)

On Sat, Apr 2, 2022 at 9:06 AM adriano-pinaffo @.***> wrote:

Ideally you should add default values for those constructors. I was going to add a pull request to fix that, but I saw there are already 2 PRs for that and nothing was merged. Maybe this project was abandoned?

— Reply to this email directly, view it on GitHub https://github.com/ghedipunk/PHP-Websockets/issues/126#issuecomment-1086658545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB46PVSRHQOSOBDB7IIOC3VDBO55ANCNFSM4JOF6A6A . You are receiving this because you are subscribed to this thread.Message ID: @.***>