Avoid duplicate pushes - Githubissues

ghedo / http2-push-nginx-module

*DEPRECATED* NGINX now supports HTTP/2 server push out of the box http://hg.nginx.org/nginx/rev/641306096f5b

BSD 2-Clause "Simplified" License

40 stars 5 forks source link

Closed StephanDollberg closed 7 years ago

StephanDollberg commented 7 years ago

Adds a per connection state to track the already pushed paths and avoid duplicate pushes.

Open questions:

Using a simple array for the path list now. Question is whether we want to switch to a better data structure. Given that nginx doesn't have a dynamic hash table we could use the ngx_rbtree. Given that pushes are limited by http2_max_pushed_streams (which doesn't seem to be implemented yet) the array might just work best.
Should we fail harder in ngx_http_v2_push_mark_as_pushed?

StephanDollberg commented 7 years ago

Interesting, clang 3.4 and 3.9 disagree on C11.

StephanDollberg commented 7 years ago

clang 3.4 is happy now as well