search

ghen-git / Thirst-Mod

Other
13 stars 10 forks source link

Crash on boot with 2.10 version of moonlight lib or supplementaries 2.8.0 #105

Closed Tomat777 closed 3 months ago

Tomat777 commented 4 months ago

https://gist.github.com/Tomat777/2ba61b06663aa1a77e40b5f0d4ec2d69

DaddySpin commented 4 months ago

same error

Vivid141 commented 4 months ago

Same issue for me. Here's my crash log. Crash Log: https://mclo.gs/SXXaUyY

ceifadorcinixtru commented 4 months ago

same here too

mlus-asuka commented 4 months ago

@DaddySpin @Vivid141 @ceifadorcinixtru @Tomat777 https://modrinth.com/mod/thirst-was-taken/version/1.20.1-1.3.6 use 1.3.6a in additional file

DaddySpin commented 4 months ago

Out of curiosity why is it an additional file instead of a full fix?

mlus-asuka commented 4 months ago

Out of curiosity why is it an additional file instead of a full fix?

I think it shouldn't be 1.3.7,because there is nothing else changed. (it has a new config value besides.)

DaddySpin commented 4 months ago

What broke with moonlight anyway?

mlus-asuka commented 4 months ago

What broke with moonlight anyway?

it changed original codes, so i need to make new compt. you can see the detail in my commit.

DaddySpin commented 4 months ago

Ah I see now.

Tomat777 commented 3 months ago

2.10 version of moonlight lib and supplementaries 2.8.0 works however 2.10.10 version of moonlight lib and supplementaries 2.8.4 doesnt work error: https://gist.github.com/Tomat777/3c0e6320b46bf5961b914981be85ad5a

mlus-asuka commented 3 months ago

2.10 version of moonlight lib and supplementaries 2.8.0 works however 2.10.10 version of moonlight lib and supplementaries 2.8.4 doesnt work error: https://gist.github.com/Tomat777/3c0e6320b46bf5961b914981be85ad5a

okay, now we have 1.3.6b

Tomat777 commented 3 months ago

yep, all good, thanks