search

ghen-git / Thirst-Mod

Other
18 stars 11 forks source link

[Question] How to add compatibility for drinking by hand from modded liquids? #154

Open DoctorVerum opened 1 month ago

DoctorVerum commented 1 month ago

Anyone know if there are any viable config options to enable driking driectly from source (sneak+right click) for modded fluid blocks? Currently this only seems to work for vanilla water sources.

I've tried adding the iterm IDs in the config list of drinkable items but that doesn't seem to change anything.

mlus-asuka commented 1 month ago

Not available. Fluid source will be infinite for hand drinking that's too op

DoctorVerum commented 1 month ago

???

I don't get the problem, I just want the ability to drink water and such added by other mods so I don't die of dehydration becase a mod uses modded fluids. This is a compatibility issue.

mlus-asuka commented 1 month ago

you mean some mods replace water with modded fluids? and in the case you can no longer find water to drink any more？

DoctorVerum commented 1 month ago

Sort of, I have mods that add other biomes and variations of water (ex. coloured water) which Thirst Was Taken seemingly can't identify as drinkable. This is fair, as obviously you don't want it to register every fluid added by mods as water since that would be very broken, but I'm trying to see if there are any ways to add compat for modded liquids.

Ex. I was curious to know if there are any tags used by Thirst Was Taken to identify what third party sources of liquids are drinkable (ex. if it had a "water" tag somewhere), so that I can add compatibility.

The mod already offers a great and easy way for adding items to be drinkable, so I can easily enable compatibility for drinking bottled variants of modded liquids, I was just curious to know about how the mod handles the "drink from source" option so I could add the ability to drink from sources added by other mods.

I understand this may be hard and I don't ask you to add any specific compatibility, I'm just curious to know more about how Thirst Was Taken "drink from source" works to see if I can enable that feature for third party sources of water that aren't normally able to be drunk from.

mlus-asuka commented 1 month ago

https://github.com/ghen-git/Thirst-Mod/blob/1.19.2/src/main/java/dev/ghen/thirst/content/thirst/DrinkByHandClient.java#L30 If you add tag for other fluids it is possible. the fluid needs FluidTags.Water

DoctorVerum commented 1 month ago

This is very helpful, thanks a lot!