search

ghenry22 / cordova-plugin-music-controls2

A Cordova plugin displaying music controls in notifications (cordova-plugin-music-controls)
MIT License
59 stars 60 forks source link

Notification in media control carousel #79

Closed silfversound closed 1 year ago

silfversound commented 2 years ago

With Android 11 and 12 you are able to have the notification in a media control carousel like this: https://android-developers.googleblog.com/2020/08/playing-nicely-with-media-controls.html

I'm getting my notification in the notifications list and not in the media control carousel. Have I missed anything or is it not implemented yet in this plugin?

bikubi commented 2 years ago

The article you mention says:

Now, the really good news. As long as you're using MediaStyle with a valid MediaSession token (both available since Lollipop API 21), media controls will be displayed for your app automatically - no extra work for you!

And I can find MediaStyle mentioned in the code, it goes back to #65, but it looks more like a shim and less like the "recap" in the article.

I suspect that the "shim" does not suffice (any more)?

EDIT: btw, I'm on Android 13 and also getting a "regular" notification and not the carousely one I know from Android 10.

bikubi commented 2 years ago

Looks like MediaStyle is missing the MediaSession token. I've fixed in my fork, seems to work; tested on Android 10 and 13 devices. https://github.com/bikubi/cordova-plugin-music-controls2/commit/47a87f309db11d2469eb6b1b973c64eea6745d19

ghenry22 commented 1 year ago

This is fixed in v3.0.7