search

gher-uliege / DIVAnd.jl

DIVAnd performs an n-dimensional variational analysis of arbitrarily located observations
GNU General Public License v2.0
72 stars 11 forks source link

Jmb #116

Closed jmbeckers closed 1 year ago

jmbeckers commented 1 year ago

bug correction

Alexander-Barth commented 1 year ago

Thanks a lot! I am wondering if we should use symbols instead of strings for such comparision, e.g. method == :auto instead of method == "auto"...

But we can still merge the PR and deal with it later

jmbeckers commented 1 year ago

Thanks a lot! I am wondering if we should use symbols instead of strings for such comparision, e.g. method == :auto instead of method == "auto"...

But we can still merge the PR and deal with it later

Yes, that would it make more uniform with respect to API of DIVAndrun etc

I will try to make the changes

jmbeckers commented 1 year ago

Thanks a lot! I am wondering if we should use symbols instead of strings for such comparision, e.g. method == :auto instead of method == "auto"... But we can still merge the PR and deal with it later

Yes, that would it make more uniform with respect to API of DIVAndrun etc

I will try to make the changes

Done

Alexander-Barth commented 1 year ago

Great, thanks a lot!