gher-uliege / DIVAnd.jl

DIVAnd performs an n-dimensional variational analysis of arbitrarily located observations
GNU General Public License v2.0
70 stars 11 forks source link

Wrong long name for lat #63

Closed ax1ine closed 4 years ago

ax1ine commented 4 years ago

Found a strange bug (?) in the netCDF output. For whatever reason long name for latitude is replaced with the one for longitude. Here's a part of the ncdump header output: 'variables:

double lon(lon) (no compression);
    lon:units = degrees_east ;
    lon:standard_name = longitude ;
    lon:long_name = longitude ;

double lat(lat) (no compression);
    lat:units = degrees_east ;
    lat:standard_name = longitude ;
    lat:long_name = longitude ;

double depth(depth) (no compression);
    depth:units = meters ;
    depth:positive = down ;
    depth:standard_name = depth ;
    depth:long_name = depth below sea level ;

'

All the other variables are fine. Don't know when it has exactly happened (as I've updated Julia modules for a few times), but files I had produced with the same script on 28 January 2020 had no such problem. I've just updated both DIVAnd (v 2.5.1) and NCDatasets (v 0.10.1) modules but the issue remains.

Upd. I use the diva3d function to produce nc files

jmbeckers commented 4 years ago

yep seems like a typo (cut and paste error?) in DIVAnd_save.jl lines 165-166.

Alexander-Barth commented 4 years ago

Thank you Alexander for letting us know! This is indeed a typo. I will update the master branch once all tests succeed on my development branch.

Alexander-Barth commented 4 years ago

Fix is now merged in master. Thanks for reporting it!

ax1ine commented 4 years ago

Great! Thank you for the prompt fix, Alexander!