gherardovarando / gmat

R package for graphically constrained correlation matrices

GNU General Public License v3.0

0 stars 3 forks source link

removed chordal stuff, made mh_u public, updated chol_polar doc #51

Closed ghost closed 5 years ago

ghost commented 5 years ago

Closes #47 and #50.

For issue #33, I have decided to remove all references to chordal and just use the dag provided (if any). Because probably in the future if we extend the work on this, we will also upgrade the package (and maybe already be able to also sample uniformly from v-structures).

Let me know if you are OK with the changes or anything needs to be updated.

codecov[bot] commented 5 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.87%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   88.21%   89.09%   +0.87%     
==========================================
  Files           5        5              
  Lines         280      275       -5     
==========================================
- Hits          247      245       -2     
+ Misses         33       30       -3

Impacted Files	Coverage Δ
R/cor_dag.R	`88.03% <100%> (+1.96%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d777a7...6b03c69. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.87%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   88.21%   89.09%   +0.87%     
==========================================
  Files           5        5              
  Lines         280      275       -5     
==========================================
- Hits          247      245       -2     
+ Misses         33       30       -3

Impacted Files	Coverage Δ
R/cor_dag.R	`88.03% <100%> (+1.96%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d777a7...6b03c69. Read the comment docs.