search

gherardovarando / gmat

R package for graphically constrained correlation matrices
GNU General Public License v3.0
0 stars 3 forks source link

Simplification and tests for ug_to_dag #63

Closed ghost closed 5 years ago

ghost commented 5 years ago

I have created a test for comparing the original undirected graph passed to ug_to_dag, with the skeleton of the returned dag, and they are not the same for p = 10 (for p = 4 no bugs are found)

codecov[bot] commented 5 years ago

Codecov Report

Merging #63 into master will increase coverage by 0.14%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   92.91%   93.06%   +0.14%     
==========================================
  Files           5        5              
  Lines         254      245       -9     
==========================================
- Hits          236      228       -8     
+ Misses         18       17       -1
Impacted Files Coverage Δ
R/cov_ug.R 98.64% <100%> (-0.02%) :arrow_down:
R/utils.R 100% <100%> (+2.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec876a4...8983ae1. Read the comment docs.