search

ghewgill / puzzles

Simon Tatham's Portable Puzzle Collection
Other
143 stars 25 forks source link

Tatham upstream merges #7

Open snelg opened 4 years ago

snelg commented 4 years ago

I've been keeping my own fork of your code up-to-date with Simon Tatham's updates over the years. Lots of little bugfixes, but he also added a new game at some point.

But at some point I also merged in a branch from some other guy's additional puzzles for the collection: https://github.com/x-sheep/puzzles-unreleased

Since you hadn't updated in years, I didn't think to keep a completely separate branch without those additional "x-sheep" puzzles. I did, however, keep my iOS build file changes in a separate branch. That separate branch is the one I've been using to build and then locally install on my iPhone and iPad. So this PR should produce a clean build that only incorporates 5 years' worth of upstream merges. It does have the x-sheep files in the source, but they're not incorporated into the build.

If you're interested in those additional puzzles, I can make different PR that includes the changes to Puzzles.xcodeproj/project.pbxproj I've been using to include them in the build.

If you're interested in the upstream merges but not the x-sheep puzzles, and you'd prefer a nice clean PR without the extra garbage, then I can make a cleaner PR for you.

If you're not interested in any of this at all, then I'll just say "thanks" for creating this iOS build in the first place :)

mld2443 commented 3 years ago

It would make my absolute day if this got merged in. I've been playing these puzzles for 12 years (😳) now, I really like palisade and would love to try out those others!

Svedalrain commented 3 years ago

@ghewgill Any chance of this happening?

Svedalrain commented 3 years ago

@snelg What barriers are there to putting this out as a second app?

snelg commented 3 years ago

@snelg What barriers are there to putting this out as a second app?

If this was Android, then I'd be fine tossing out an .apk file into the wild for people to install on their own. Since iOS is such a walled garden, though, I'd pretty much have to go through the rigmarole of formally registering and publishing on the App Store. That's more hassle than I need in my life right now :)

mld2443 commented 3 years ago

@snelg What barriers are there to putting this out as a second app?

If this was Android, then I'd be fine tossing out an .apk file into the wild for people to install on their own. Since iOS is such a walled garden, though, I'd pretty much have to go through the rigmarole of formally registering and publishing on the App Store. That's more hassle than I need in my life right now :)

I'm interested, is it really that challenging? (other than the iOS developer license fee)

It's been 7 months, pretty sure @ghewgill has no interest in updating.

snelg commented 3 years ago

I'm interested, is it really that challenging? (other than the iOS developer license fee)

Not really "challenging," just annoying :)

ghewgill commented 3 years ago

Sorry all, not really challenging but my Mac had died last year and I just got a shiny new M1 Mini. So I now have the ability to update this. Just have to find the time in between everything else.

NLZ commented 2 years ago

Not sure if you would be willing to make the effort, but I would be really happy if you could release your version in the App Store.