search

ghewgill / senotifier

Stack Exchange Inbox Notifier
http://stackapps.com/questions/3081/senotifier-a-stack-exchange-inbox-notifier-for-mac-os-x
Other
100 stars 18 forks source link

Notification Center support added #9

Closed ppeelen closed 11 years ago

ppeelen commented 11 years ago

Hi!

I added support for the Notification Center. Added the menu item for it as well. Seems to work nicely, however I haven't fully tested click method, it should work though.

Also, I did a re-indentation on the delegate file, hence the many changes it seems to have

@todo: Need to add support in applicationDidFinishLaunching: which I didn't have time for to add.

ghewgill commented 11 years ago

Thanks! I can't really use this patch as-is, because you've included unrelated files (in xcuserdata) and you have reindented the source code. Changing formatting on a large scale like that in combination with another patch is normally unacceptable. I will attempt to extract the relevant parts of your changes as notification center support will be good to have.

ppeelen commented 11 years ago

Hi,

Nice to know. I might be able to revert the indentation changes, which I understand is unacceptable, however I currently am out of town skiing this week... Maybe I have some time during an evening otherwise I can look at it next week.

Let me know if I can do anything to help you.

Best regards, Paul Peelen

Paul Peelen Paul@Peelen.se

https://twitter.com/PPeelen

15 jan 2013 kl. 08:24 skrev Greg Hewgill notifications@github.com:

Thanks! I can't really use this patch as-is, because you've included unrelated files (in xcuserdata) and you have reindented the source code. Changing formatting on a large scale like that in combination with another patch is normally unacceptable. I will attempt to extract the relevant parts of your changes as notification center support will be good to have.

— Reply to this email directly or view it on GitHub.

ghewgill commented 11 years ago

Enjoy your skiing, don't worry about coding. :) I have extracted the relevant changes from your pull request and am working on integrating them into the code base.

ghewgill commented 11 years ago

The master branch now has notification center support, let me know how it works for you!

ppeelen commented 11 years ago

Awesome. I'll have a look asap.

Br, Paul

Paul Peelen Paul@Peelen.se

https://twitter.com/PPeelen

15 jan 2013 kl. 10:38 skrev Greg Hewgill notifications@github.com:

The master branch now has notification center support, let me know how it works for you!

— Reply to this email directly or view it on GitHub.