search

ghex-org / GHEX

Generic exascale-ready library for halo-exchange operations on variety of grids/meshes
Other
8 stars 14 forks source link

Support for GT2.2 #145

Closed fthaler closed 2 years ago

fthaler commented 2 years ago

GridTools 2.2 removes gridtools/meta/type_traits.hpp, as this was providing ports to C++14 for some traits introduced to the STL with C++17 (which is a requirement for GridTools version ≥ 2.2). With this PR, GHEX supports both GridTools versions < 2.2 with C++14 (or C++17) and GridTools versions ≥ 2.2 with C++17.

bettiolm commented 2 years ago

Sure, that's ok for me. Only thing is that we should probably also change set(CMAKE_CXX_STANDARD 14) to 17 in the main CMakeLists.txt.

fthaler commented 2 years ago

I don’t know if you want to introduce that change with this PR. This is just a compatibility fix for GT 2.2 (which only supports C++ 17), but GHEX still supports GT ≥ 2.0 with C++14. But of course I could add that…

bettiolm commented 2 years ago

Yep, agree. Sure, Let's keep the CMake part as it is then, maybe we will change it later. From my side, we can just merge the PR.

fthaler commented 2 years ago

Thanks! Could you please merge it then, I don’t have write access :)