Some fixes - Githubissues

angainor commented 3 years ago

required cmake version is too high. what should it be? fix pool::free - did not remove freed segments from m_segments (segfault) fix pool::allocate - counter did not get increased

boeschf commented 3 years ago

yes, clearly a bug in the free. fix seems good
same for counter
cmake version 3.17 is required for find_package(CUDAToolkit REQUIRED) (see src/CMakeLists.txt). If we can provide a workaround for this, then we can lower the requirements on the version

angainor commented 3 years ago

It's not an issue really. If your need it then it's fine. I reverted it, np.

On Fri, May 14, 2021, 14:23 boeschf @.***> wrote:

I applied the bug fixes in #14 https://github.com/boeschf/hwmalloc/pull/14 CMake version should maybe go into a separate issue, what do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/boeschf/hwmalloc/pull/13#issuecomment-841209680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3LYKHQH2ZVQNFB4X374HLTNUI2NANCNFSM444IW64Q .

ghex-org / hwmalloc

Some fixes #13