search

ghfields / rpooler

A guided installation script for zfs rpools
29 stars 6 forks source link

Add default option to reboot step #30

Closed ThomDietrich closed 5 years ago

ThomDietrich commented 5 years ago

This step seemed unintuituve and was differed from the rest of the script

ghfields commented 5 years ago

I originally wrote the reboot option like that. I changed it because I thought explicit keyboard entry to acknowledge reboot, instead of mindlessly hitting enter would be better. It is designed for people may want to do additional tweaks before leaving the liveCD environment.

Since the pools have already been exported etc., it takes some effort to get back to the state you can do these changes to the dataset. Anyone willing to do this might as well be trusted to not just mindlessly accept script defaults.

Sure. Lets change this. Thanks for the suggestion.

ThomDietrich commented 5 years ago

I agree :)