search

ghidinelli / cfpayment

ColdFusion payment processing library makes plumbing e-commerce apps easy. Charging credit cards has never been easier. Inspired by Ruby's ActiveMerchant.
Other
90 stars 54 forks source link

Make Stripe marketplace methods more idiomatic #18

Closed ghidinelli closed 9 years ago

ghidinelli commented 9 years ago

Review of marketplace appears to have multiple highly-overlapping methods where just the arguments change:

purchase() charge() marketplaceDirectCharge() marketplaceDestinationCharge()

The behavior, depending on the parameters, is quite different but this more clearly matches the Stripe API too so collapsing them into the cfpayment-standard methods makes sense.

ghidinelli commented 9 years ago

All marketplace functions take an "amount" argument which should be "money".