ghidinelli / cfpayment

ColdFusion payment processing library makes plumbing e-commerce apps easy. Charging credit cards has never been easier. Inspired by Ruby's ActiveMerchant.
Other
90 stars 54 forks source link

Stripe addCreateManagedAccountData() has hardcoded account data #21

Closed ghidinelli closed 9 years ago

ghidinelli commented 9 years ago

marketplaceCreateConnectedAccount() calls the above method which has hardcoded test data and will not work in real scenarios:

<cfscript>
    arguments.post["managed"] = true;
    arguments.post["country"] = 'CA';
    arguments.post["email"] = 'test#dateFormat(now(),"yyyymmdd")##timeFormat(now(),"HHmmss")#@test.tst';
    arguments.post["default_currency"] = 'CAD';
    //These properties can be set when creating the account, and changed later if the account is managed, but are only relevant if the account has charges being made directly on it:
    //arguments.post["statement_descriptor"] = '';
    //arguments.post["business_name"] = '';
    //arguments.post["support_phone"] = '';
</cfscript>
ghidinelli commented 9 years ago

testMarketplaceCreateConnectedAccount needs to be updated to test passing in some data and verifying it's what we get back