Not great for Ruby development - Githubissues

ghifarit53 / tokyonight-vim

A clean, dark vim colorscheme that celebrates the lights of downtown Tokyo at night, based on a VSCode theme by @enkia with the same name [Archived because I'm no longer using this]

MIT License

557 stars 48 forks source link

Not great for Ruby development #17

Open stoicAlchemist opened 3 years ago

stoicAlchemist commented 3 years ago

I'm working for a private company (can't share screenshots) but I can say I love your theme but I can't use it because our project uses Ruby and Ruby on Rails and it shows so pale with so few stuff highlighted. Could you take a look into adding support for some keywords? Just from the top of my mind:

Starting with "@" symbol means it's an instance var: "@instance_variable"
Starting with ":" symbol means it's a ruby symbol: ":symbol"
Followed by ":" is a symbol used as key on a hash (like a map): "key: 'value'" and also "key with spaces": 'value'
And finally, two words separated by spaces means the left one is the method name and the following is an argument; with the exceptions of already detected reserved keywords (while, for, if, def, class, module, case... etc)

I'm not sure how syntax highlight works, I'm assuming it's detecting keywords as tokens and giving them token type? Let me know if there is something I can do to help.

stoicAlchemist commented 3 years ago

Forgot to mention, "@@variable" is a class variable

eduvim commented 3 years ago

@stoicAlchemist I think that https://github.com/sheerun/vim-polyglot works well . Did you test a different theme using polyglot ? I don't think that this is a responsibility of this repo , you should look to the package that you are using for highlighting

stoicAlchemist commented 3 years ago

I'm using polyglot and it still doesn't show those tokens highlighted

stoicAlchemist commented 3 years ago

added a screenshot: screenshot

eduvim commented 3 years ago

It's working properly for me . I think that the problem for you is being caused by some other plugins that you have installed. Would you mind to share your .vimrc please , i'm using this file just for reference https://github.com/eduvim/confsyncher/blob/main/example/vimrc.template. It would be also helpful that you review your vim binary in order to check if termguicolors is available

stoicAlchemist commented 3 years ago

Sure thing, my configs are: https://github.com/stoicAlchemist/dotfiles/tree/main/nvim

pabuisson commented 3 years ago

I will +1 on this. Using polyglot too, and coding a lot with Ruby, but I have many tokens not highlighted compared to the other themes I used with the same vimrc, symbols being the most obvious one.

Isn't this a problem of which highlighting groups are customised versus which ones are using the default colors?