search

ghiffaryr / grplot

BSD 3-Clause "New" or "Revised" License
32 stars 2 forks source link

Is max_y typo or not? #24

Closed renardelyon closed 1 year ago

renardelyon commented 1 year ago

https://github.com/ghiffaryr/grplot/blob/27c54f4704bb7537429cf56ca63e1cfc0d4cd1ce/grplot/features/text/text_def.py#L454

@ghiffaryr ini memang max_y atau typo harusnya min_y

ghiffaryr commented 1 year ago

harusnya typo itu, baru sadar juga. ginilah kalo ngoding sendiri wkwkwk. tar gua perbaiki sekalian update fitur filter. lagi chaos deadline sama belum sembuh total covid gua.

renardelyon commented 1 year ago

cepet sembuh lah, sama ini gw aja yang ganti gw lagi ngerefactor text_def jadi pake prinsip SOLID biar lebih scalable sma readable