search

ghiffaryr / grplot

BSD 3-Clause "New" or "Revised" License
32 stars 2 forks source link

Create unit test #4

Open renardelyon opened 2 years ago

renardelyon commented 2 years ago

Overview

This repo still lack unit test

Ghiffary

Lyon

renardelyon commented 2 years ago

@ghiffaryr kalo misal PR unittest buat per foldernya bikin branch baru ya biar enak ngereviewnya

renardelyon commented 2 years ago

@ghiffaryr ini gimana cara biar set_rotationnya ngasih error?

def rot_def(ax, axis, rot):
    if axis == 'x':
        try:
            for label in ax.get_xticklabels():
                label.set_rotation(rot)
        except:
            raise Exception('Unknown rot argument!')
    elif axis == 'y':
        try:
            for label in ax.get_yticklabels():
                label.set_rotation(rot)
        except:
            raise Exception('Unknown rot argument!')
    else:
        raise Exception('Unsupported axis!')
    return ax
ghiffaryr commented 2 years ago

@ghiffaryr kalo misal PR unittest buat per foldernya bikin branch baru ya biar enak ngereviewnya

boleh sih

renardelyon commented 2 years ago

bukan comment yang itu, comment bawahnya