search

ghiggi / gpm_api

Global Precipitation Measurement Mission (GPM) python package to download and analyze data with xarray
https://gpm-api.readthedocs.io
MIT License
57 stars 6 forks source link

Add utils tests #24

Closed sphamba closed 10 months ago

sphamba commented 10 months ago

Summary

Add tests for:

coveralls commented 10 months ago

Coverage Status

coverage: 52.743% (+8.8%) from 43.96% when pulling 41baf42c78ccfb63bda6970d0772b2e248403807 on EPFL-ENAC:feat-utils-tests into 11c8b3fc4cf53d37814ee784afa39b7376e884bd on ghiggi:main.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dd1d1fc) 43.95% compared to head (41baf42) 52.74%. Report is 1 commits behind head on main.

Files Patch % Lines
gpm_api/utils/checks.py 95.23% 1 Missing :warning:
gpm_api/utils/slices.py 97.36% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== + Coverage 43.95% 52.74% +8.78% ========================================== Files 64 64 Lines 5339 5377 +38 ========================================== + Hits 2347 2836 +489 + Misses 2992 2541 -451 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sphamba commented 10 months ago

I adressed your comments! Regarding the change of behavior of get_slices_*, we can do it in a separate PR, and we can see where you want me to spend time