Segment.contains contains an error

[richardalligier]

Hi,

There is a mistake on Segment.contains. You should use Point.distance instead of Point.sq_distance.

Best regards, Richard

[richardalligier]

Furthermore, inside Circle.segment_intersection, instead of using Segment.contains, you could just check that the dot_product of the vector (a,p) and (a,b) is between 0 and (sq_distance a b) where we want to check if p is inside [a;b]. It could be more reliable because we already know that the point p is on the line defined by (a,b)

[ghilesZ]

Thanks for the issue. Do you by any chance have a fix? if not i will correct it this week-end

[richardalligier]

I made a pull request

[ghilesZ]

Great! Thank you again, i'm closing this issue