search

ghilesZ / geoml

A 2d geometry library for ocaml
GNU Lesser General Public License v2.1
35 stars 5 forks source link

Compilation fails #9

Closed tbrup closed 4 years ago

tbrup commented 4 years ago

Not sure if this is a pilot error...

After cloning the repo, compiling with make gives these error messages:

dune build src/geoml.cma Entering directory '/Users/thomasbrupbacher/temp' File "geoml/src/constraint.mli", line 7, characters 18-24: 7 | type t = private Line.t comp ^^^^^^ Error: Unbound type constructor Line.t File "geoml/src/polygon.mli", line 5, characters 17-24: 5 | type t = private Point.t list ^^^^^^^ Error: Unbound type constructor Point.t File "geoml/src/curve.ml", line 4, characters 11-18: 4 | type t = Point.t Point.t * Point.t ^^^^^^^ Error: Unbound type constructor Point.t make: *** [build] Error 1

Being relatively new to Ocaml, I have no idea how to fix this.

Environment: MacOS 10.14.x Ocaml 4.08.1

ghilesZ commented 4 years ago

Yes some unfinished implementation have been pushed in a barbaric style on master. commit 3e8fb4f91788e01f761be03db9947b83066d74fd should fix this. Can you confirm it so i close the issue? Thanx.

tbrup commented 4 years ago

Just tried it and it does work.

Thanks!

ghilesZ commented 4 years ago

ok thanks