ghiscoding / Angular-Slickgrid

Angular-Slickgrid is a wrapper of the lightning fast & customizable SlickGrid datagrid, it also includes multiple Styling Themes
https://ghiscoding.github.io/Angular-Slickgrid
Other
397 stars 120 forks source link

`showGridMenu()` is triggered when we hit ENTER key on the inline filter #447

Closed thisisyazhini closed 4 years ago

thisisyazhini commented 4 years ago

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular 8.2.14
Angular-Slickgrid 2.17.11
TypeScript 3.5.3

Describe the Bug

showGridMenu() is getting triggered when the user hits ENTER key after entering the search term on the compoundInputNumberFilter

Steps to Reproduce

  1. Enable filtering and use Filters.compoundInputNumber on a field.
  2. Set the gridmenu with the below configuration.
  3. In a compoundInputNumber field, type your search term and hit enter. Current setup gridMenu Configurations
    this.gridOptions = {
      gridMenu: {
        hideForceFitButton: true,
        columnTitle: '',
        hideRefreshDatasetCommand: true,
        iconCssClass: 'fa fa-bars'
      }
    //Other options for filters

    Expected Behavior

    The grid menu shouldn't show in the screen at all, when the user hits enter key after entering a search term for inline filtering.

Current Behavior

When we hit enter key in the inline filtering, the library is implicitly invoking the showGridMenu() and the gridMenu shows up on Left side of the screen. The shown menu is ONLY partially visible. image

Possible Solution

Code Sample

ghiscoding commented 4 years ago

I can't reproduce this, I don't think any of the demos are showing this behavior. Also the showGridMenu is a method on the Grid Menu plugin and it's not really an event, so why are you using it as an event? So you most probably have some extra code that you did not include in this issue. I can't help unless you provide necessary code to replicate this.

thisisyazhini commented 4 years ago

Thanks for your swift reply. This is reproducible in your demo page as well. If you focus on the Grid menu like in the below screenshot and hit enter in the keyboard, you should be able to see the grid menu opening on the left side of the screen. image In our application, when we focus out of a cell, somehow the focus was going on to the grid menu and on hitting enter, it used to open the grid menu on the Left side of the screen. Thanks much !

ghiscoding commented 4 years ago

hmm this Grid Menu was never meant to be used from the keyboard. This is an issue with SlickGrid (core) lib, it can be reproduced in this SlickGrid Example.

Can you please open an issue in the core lib SlickGrid instead. There's nothing to fix in Angular-Slickgrid, it will have to be fixed in the core lib. Once it's fixed in the core, it will flow to Angular-Slickgrid.

thisisyazhini commented 4 years ago

Thanks much for having looked into this. Sure, I have raised an issue in SlickGrid library.

ghiscoding commented 4 years ago

Thanks, I'll close this issue here then

ghiscoding commented 4 years ago

This issue will be fixed in the core lib by this PR #491

ghiscoding commented 4 years ago

This is now available in latest version 2.18.x.

Please upvote ⭐ if you haven't already. Cheers