search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

multiple selection mode not always working #22

Closed amayr666 closed 6 years ago

amayr666 commented 6 years ago

Hi, setting the multiple="true" attribute doesn't always work since the check in abp-select.js on line 77 this.multiple = this.util.parseBool(this.multiple || this.elm.getAttribute('multiple')); requires the form multiple="true", but just multipleis also valid html. This breaks some browsers/Servers.

regards

ghiscoding commented 6 years ago

Pull Request are welcome if you want to fix it.

ghiscoding commented 6 years ago

Alright it's all done, please note that I have decided to increase the version to 1.0.0 (as shown on NPM) to make it officially release and align with the other plugins which were already as 1.x. By the way, since I was at it, I also made the change on the disabled attribute.

Thanks for the feedback and PR, if you like the plugin, you could also upvote :)