search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

Bootstrap 4 dropped support for input-group-addon #36

Closed jereckley closed 6 years ago

jereckley commented 6 years ago

So this can be fixed by specifying bootstrap@4.0.0-beta.2 but still something that needs to be addressed: Bootstrap 4 is dropping support for input-group-addon so 4.0.0-beta.3 breaks the date picker.

New format requires bootstrap input-group-prepend and input-group-append with a nested <span class="input-group-text">icon here</span>.

ghiscoding commented 6 years ago

would it be possible to make a PR that would work with both versions?

ghiscoding commented 6 years ago

Fixed in latest version NPM 1.1.0, new Global Options were added to deal with this, so make sure to change the bootstrapVersion = 4 in your Global Options. You can see some references in the Global Options readme. I also added another global option to change the Bootstrap 4 button class, I used btn-outline-secondary by default, again look at the Global Options to know more about that.

jereckley commented 6 years ago

Awesome turn around! Thanks

ghiscoding commented 6 years ago

Oops, I forgot to remove the bootstrapVersion flag that I added to the View while testing it. Pushed another version on NPM 1.1.1

Here's what it looks line in the final 2018-01-06_18-28-18