search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

Support FontAwesome 5 with DateTimePicker #43

Closed Cali03 closed 6 years ago

Cali03 commented 6 years ago

Hi,

Here you have my changes for support FontAwesome 5. I change the calendar icon to calendar-alt, i prefer it :)

Thanks

ghiscoding commented 6 years ago

@Cali03 Have you tested it? I can merge it a bit later today but I won't have time to test anything since I'm going in vacation tomorrow.

Cali03 commented 6 years ago

Hi @ghiscoding ,

Of course i have tested it. it work great just need to set config.extra.iconBase = 'font-awesome-5'

It's not an urgent question for me so you can merge it when you come back.

Enjoy your vacation.

ghiscoding commented 6 years ago

I'll merge it this evening and push a release, thanks for confirming

ghiscoding commented 6 years ago

You missed a curly brace closing here which I had to fix to make it build properly.

It is now release under version 1.2.0 on NPM

Cali03 commented 6 years ago

Hi,

I just copied the else ... Sorry ... Fucking copy & paste

Thanks