search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

fix(select) cleanup, fix endless recursion on selection updates #56

Closed Mobe91 closed 6 years ago

Mobe91 commented 6 years ago

Fixes #55 and possibly also #54. I tested the changes with the demo application in /doc and it all seems to work fine.

ghiscoding commented 6 years ago

Thanks, will take a look at it over the weekend

ghiscoding commented 6 years ago

There's a lot of changes in that PR. It seems to be running all fine and I'm ok with the changes, seems to be an improvement and it's also simpler in some areas.

Side note, now I remember about the endless loop, it's caused by the selectedValueChanged triggering a selectedItemChanged and the ball keeps rolling. Which is why it's important to have the proper checks in each to avoid such endless loop.

Since there are a lot of changes, I decided to push a Minor version 1.3.0 instead of just a patch version. Thanks for the PR.