search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

fix(select) issue #68 Optgroup doesn't work if there are fewer option… #69

Closed jmurphy-asurity closed 5 years ago

jmurphy-asurity commented 5 years ago

…s than the group index

jmurphy-asurity commented 5 years ago

I added another commit which fixes two more selected(Value|Item)Changed infinite loop cases, and ignores disabled options when setting selectedValue or selectedItem

ghiscoding commented 5 years ago

Thanks it will take me couple days to test it out, so please be patient. I always welcome PR :)

jmurphy-asurity commented 5 years ago

Great, no hurry on my part. Thanks for the great plugin. It's very useful

ghiscoding commented 5 years ago

Looks ok except that running the linter with gulp lint shows up few warnings. The most common one is that it requires all line to finish with semicolons. I will merge and push another commit to address these warnings