search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

Not working well with custom format #8

Closed cristhian-net closed 7 years ago

cristhian-net commented 7 years ago

I think it is a bug. My format is 'DD/MM/YYYY hh:mm A', but it throws an error every time I change the date, and causes model to be invalid date. So I have changed 1 line and now it is working. I will submit a PR. The code was not taking into account when a custom format was set (just calling moment(date).toDate()).

cristhian-net commented 7 years ago

PR submitted

ghiscoding commented 7 years ago

hello @CristhianUNSa thanks a lot for the PR, I will review it possibly tomorrow. Sorry about the delay as I was away in vacations for the past few weeks.

cristhian-net commented 7 years ago

@ghiscoding no problem, and thank you for your time :+1:

ghiscoding commented 7 years ago

Thanks for the Pull Request, I made a new release 1.0.6, now updated on NPM. This new release include both modelChanged and valueChanged with a strict format changed. So thanks again :)

cristhian-net commented 7 years ago

@ghiscoding thanks I was waiting for it on npm ! :)

ghiscoding commented 7 years ago

Great, let me know if that fixes your issue. Thanks ;)