search

ghiscoding / Aurelia-Bootstrap-Plugins

Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons
https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins
MIT License
45 stars 23 forks source link

Update valueChanged for strict parsing with format #9

Closed cristhian-net closed 7 years ago

cristhian-net commented 7 years ago

Was not working with 'DD/MM/YYYY hh:mm A' format. This change works well for me, but I have not tested it. But as I can see in line 285, it already takes care of that moment date to be valid. Then I think it will work for other use cases.

ghiscoding commented 7 years ago

This is good, we should however replicate the same exercise for both the modelChanged and valueChanged. I will merge your code and add it as well on modelChanged. The quick tests I made seems all good on my side.

Thanks

ghiscoding commented 7 years ago

Thanks for the Pull Request, I made a new release 1.0.6, now updated on NPM. This new release include both modelChanged and valueChanged with a strict format changed. So thanks again :)